refactor: consolidate result type #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Apr 11, 2025
|
|
||
| /// \brief Result alias | ||
| template <typename T, typename E = typename DefaultError<T>::type> | ||
| using Result = expected<T, E>; |
Member
There was a problem hiding this comment.
Should we default T to void so we can simply use Result as the return type if nothing to return?
Member
There was a problem hiding this comment.
We could also add using Status = expected<void, Error>?
Contributor
Author
There was a problem hiding this comment.
Good idea, I will uniformly modify the places where expected<void, Error> is used
wgtmac
approved these changes
Apr 11, 2025
zhjwpku
approved these changes
Apr 11, 2025
Collaborator
zhjwpku
left a comment
zhjwpku
left a comment
There was a problem hiding this comment.
Finally, it's Result and Status, thanks ;)
lidavidm
approved these changes
Apr 11, 2025
Member
Xuanwo
approved these changes
Apr 11, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
The community has reached a consensus. Let's move forward!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.